[pull] main from immich-app:main - #884
Merged
Merged
Conversation
* fix(ios-widget): send date-only value for memories query param Server v3.0.3 (#29907) validates the /memories `for` query param with a date-only schema (YYYY-MM-DD). The iOS widget still sent a full ISO 8601 datetime, so every request 400s and the widget shows "Unable to connect to your Immich instance" on any server >= v3.0.3. Build the value from the local calendar day, matching what the web client (memory-manager.svelte.ts) and Android already send, instead of a UTC datetime. Also fix a related bug in the timeline provider: fetchMemory was called with a bare try inside a Task, so a failure silently dropped the error and never called completion, leaving the widget in a stale state instead of showing an error card. Wrap it in a guard/try?, same pattern already used in getSnapshot. Fixes #30044 Signed-off-by: ajuijas <189517297+ajuijas@users.noreply.github.com> * address review: drop unrelated widget change and comment Signed-off-by: ajuijas <189517297+ajuijas@users.noreply.github.com> --------- Signed-off-by: ajuijas <189517297+ajuijas@users.noreply.github.com> Co-authored-by: ajuijas <189517297+ajuijas@users.noreply.github.com> Co-authored-by: Santo Shakil <santoshakil@users.noreply.github.com>
Co-authored-by: Daniel Dietzler <36593685+danieldietzler@users.noreply.github.com> Co-authored-by: Daniel Dietzler <mail@ddietzler.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )